-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Tokio types in a configurable runtime #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikayla-maki
force-pushed
the
cross-rt
branch
from
February 20, 2024 18:23
d145f31
to
532591e
Compare
mikayla-maki
force-pushed
the
cross-rt
branch
from
February 26, 2024 23:56
e1f071e
to
1746ddc
Compare
mikayla-maki
force-pushed
the
cross-rt
branch
from
February 28, 2024 05:27
cfd6bec
to
aee71bb
Compare
mikayla-maki
force-pushed
the
cross-rt
branch
from
February 28, 2024 05:28
aee71bb
to
b3cf18a
Compare
theomonnom
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! lgtm, going to test the changes with the python-sdk and merge the PR
thanks!
// and print all incoming events | ||
|
||
fn main() { | ||
async_std::task::block_on(async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a thin compatibility layer over the rust runtime ecosystem.
TODO:
Switch from async default to tokio defaultN/A, CI is currently broken